[ 
https://issues.apache.org/jira/browse/HBASE-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724997#action_12724997
 ] 

stack commented on HBASE-1385:
------------------------------

.bq ..for the TestTimeRangeMapRed to pass...

Can you change the test to only expect one version?

.bq So I can either add it myself on a higher level and hope for the best...

Odd that InputSplit is itself not Writable, but yeah, it should be.

.bq I have not yet removed the specializations from TableMapper/Reducer since I 
would like to see if we can find out its original motivation

I did it when I moved our MR to be 'generic':

r611488 | stack | 2008-01-12 13:32:46 -0800 (Sat, 12 Jan 2008) | 2 lines

HADOOP-2548 Make TableMap and TableReduce generic

So, the specialization of IBW is not needed -- an overreaction on my part.  
Please go ahead with your suggestion and make it better.



> Revamp TableInputFormat, needs updating to match hadoop 0.20.x AND remove bit 
> where we can make < maps than regions
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1385
>                 URL: https://issues.apache.org/jira/browse/HBASE-1385
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.21.0
>
>         Attachments: 1385-v4.patch, 1385-v5.patch, 1385.patch, mr.patch
>
>
> Update TIF to match new MR.
> Remove the bit of logic where we will use number of configured maps as splits 
> count rather than regions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to