[
https://issues.apache.org/jira/browse/HBASE-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725340#action_12725340
]
Lars George commented on HBASE-1385:
------------------------------------
Stack,
bq. Can you change the test to only expect one version?
Yes and no. I changed the lot to use Scan's, which now convey the values over
to the TIF. But one caveat for the time being, Configuration is missing a
setWritable()/getWritable() combination that would allow to hand in any
Writable into a Job. Maybe we should suggest that to the core team?
For the time being I have to extract the values from the given Scan and set
them as strings into the config just to recreate them on the other end in the
TableInputFormat. The problem with that is that the filter is missing right
now. The filter is in transition anyways and mostly commented out in the TIF
code - I was able to remove it as the Scan use should take care of it - but
that needs a proper test!
I also removed the specialization from TableMapper and TableReducer as
discussed.
Every new test passes but the TextTableIndex one. I am looking into it right
now. But otherwise this should be a complete patch and needs proper reviewing.
While a lot is quite straight forward and should work, the most extensive one
is TableInputFormat and TableInputFormatBase which now use the Scan class as
mentioned above.
> Revamp TableInputFormat, needs updating to match hadoop 0.20.x AND remove bit
> where we can make < maps than regions
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-1385
> URL: https://issues.apache.org/jira/browse/HBASE-1385
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.21.0
>
> Attachments: 1385-v4.patch, 1385-v5.patch, 1385-v6.patch, 1385.patch,
> mr.patch
>
>
> Update TIF to match new MR.
> Remove the bit of logic where we will use number of configured maps as splits
> count rather than regions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
