[
https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790157#action_12790157
]
Lars Francke commented on HBASE-1744:
-------------------------------------
Thanks for the comments!
I will have a look at the filters and see which can be easily implemented. I
also only just found out about the {{union}} keyword in Thrift which might be a
good idea for this so I'll have a look but only after I've finished the rest.
I have no strong opinion about the functions of HBaseAdmin so I'm fine either
way. I could also offer an optional AdminThriftServer so that it is separated
from the client stuff.
There is a {{closeScanner}} method in there somewhere :)
I don't quite understand what you mean with thrift explanation? Do you mean the
comment at the beginning of the file explaining what Thrift is? I just kept it
from the previous version but I'll work on expanding the package.html too.
'Text' is gone now, I was wondering about that but forgot to mention it.
> Thrift server to match the new java api.
> ----------------------------------------
>
> Key: HBASE-1744
> URL: https://issues.apache.org/jira/browse/HBASE-1744
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Tim Sell
> Assignee: Tim Sell
> Fix For: 0.21.0
>
> Attachments: Hbase.thrift, thriftexperiment.patch
>
>
> This mutateRows, etc.. is a little confusing compared to the new cleaner java
> client.
> Thinking of ways to make a thrift client that is just as elegant. something
> like:
> void put(1:Bytes table, 2:TPut put) throws (1:IOError io)
> with:
> struct TColumn {
> 1:Bytes family,
> 2:Bytes qualifier,
> 3:i64 timestamp
> }
> struct TPut {
> 1:Bytes row,
> 2:map<TColumn, Bytes> values
> }
> This creates more verbose rpc than if the columns in TPut were just
> map<Bytes, map<Bytes, Bytes>>, but that is harder to fit timestamps into and
> still be intuitive from say python.
> Presumably the goal of a thrift gateway is to be easy first.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
