[ 
https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837873#action_12837873
 ] 

stack commented on HBASE-2254:
------------------------------

Great stuff Lars (and Patrick).

I agree ant and ivy stuff should be removed.  We should do that in separate 
issue and it'd be great if stargate didn't duplicate jars.   I'll wait on 
Paul's review before committing.  He might have stuff to add.



> Improvements to the Maven POMs
> ------------------------------
>
>                 Key: HBASE-2254
>                 URL: https://issues.apache.org/jira/browse/HBASE-2254
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Lars Francke
>            Priority: Minor
>         Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, 
> hbase-2254-3.patch, HBASE-2254-4.patch, HBASE-2254-5.patch, hbase2254.sh
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are 
> a few small problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll 
> unfortunately be edited by humans so I hope these "whitespace only" changes 
> are acceptable
> * I've introduced the sourceEncoding property to be used instead of the 
> encoding parameters for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement 
> section and defined the plugin versions
> * I've fixed a type in the compiler plugin  showDeprecations -> 
> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to