[
https://issues.apache.org/jira/browse/HCATALOG-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119548#comment-13119548
]
jirapos...@reviews.apache.org commented on HCATALOG-74:
-------------------------------------------------------
bq. On 2011-10-03 19:04:11, David Capwell wrote:
bq. >
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java,
line 120
bq. > <https://reviews.apache.org/r/2061/diff/2/?file=47370#file47370line120>
bq. >
bq. > Put.add(fam, qual, value) will create a new KeyValue with timestamp
= HConstants.LATEST_TIMESTAMP. This will cause the server to set what the
timestamp should be (Put's timestamp). If we are expecting it to be
outputVersion.longValue(), can we set it during the add as well?
This is what's in Put.java
public Put add(byte [] family, byte [] qualifier, byte [] value) {
return add(family, qualifier, this.ts, value);
}
It uses a timestamp that's been set via the constructor which is what this code
in ResultConverter does:
res = new Put(put.getRow(),outputVersion.longValue());
- Francis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2061/#review2278
-----------------------------------------------------------
On 2011-10-03 13:21:56, Francis Liu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2061/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-03 13:21:56)
bq.
bq.
bq. Review request for hcatalog and Vandana Ayyalasomayajula.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. ResultConverter needed by hbase input and output storage drivers as
described here:
bq.
bq.
https://cwiki.apache.org/confluence/display/HCATALOG/HBase+Output+Storage+Driver+-+Design
bq.
bq.
bq. This addresses bug hcatalog-74.
bq. https://issues.apache.org/jira/browse/hcatalog-74
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/ResultConverter.java
PRE-CREATION
bq. storage-drivers/hbase/src/test/all-tests PRE-CREATION
bq. storage-drivers/hbase/src/test/excluded-tests PRE-CREATION
bq. storage-drivers/hbase/src/test/log4j.xml PRE-CREATION
bq.
storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseSerDeResultConverter.java
PRE-CREATION
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java
PRE-CREATION
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2061/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Francis
bq.
bq.
> ResultConverter for HBase Storage Drivers
> -----------------------------------------
>
> Key: HCATALOG-74
> URL: https://issues.apache.org/jira/browse/HCATALOG-74
> Project: HCatalog
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Labels: HBASE
> Attachments: result_converter.patch, result_converter_rev2.patch,
> result_converter_rev3.patch
>
>
> ResultConverter and an implementation which wraps hive's HBaseSerDe needed by
> the storage drivers: HCATALOG-73 and HCATALOG-75
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
