[
https://issues.apache.org/jira/browse/HCATALOG-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119550#comment-13119550
]
jirapos...@reviews.apache.org commented on HCATALOG-74:
-------------------------------------------------------
bq. On 2011-10-03 13:24:37, Francis Liu wrote:
bq. >
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java,
line 32
bq. > <https://reviews.apache.org/r/2061/diff/2/?file=47369#file47369line32>
bq. >
bq. > vandana, shouldn't this be prefixed with "hcat."? Also please
include "input" as part of the name of the constant and the value for clarity.
Use camelhumps as well ...inputTableName?
bq.
bq. Vandana Ayyalasomayajula wrote:
bq. Francis,
bq.
bq. This property is being used by the TableInputFormat internally to get
information about the hbase table to be read. So this property cannot be
changed. However, what we can do is that we can have another property with
prefix 'hcat.' . We will then have to populate the property
"hbase.mapreduce.inputtable" with the value from new property. But, still we
will have the original property in the HBaseConstants !!.
I see, then you shouldn't add a new constant for that and just use
TableInputFormat constant but if you need something that can be exposed to the
user then you prolly should create another one.
- Francis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2061/#review2261
-----------------------------------------------------------
On 2011-10-03 13:21:56, Francis Liu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2061/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-03 13:21:56)
bq.
bq.
bq. Review request for hcatalog and Vandana Ayyalasomayajula.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. ResultConverter needed by hbase input and output storage drivers as
described here:
bq.
bq.
https://cwiki.apache.org/confluence/display/HCATALOG/HBase+Output+Storage+Driver+-+Design
bq.
bq.
bq. This addresses bug hcatalog-74.
bq. https://issues.apache.org/jira/browse/hcatalog-74
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/ResultConverter.java
PRE-CREATION
bq. storage-drivers/hbase/src/test/all-tests PRE-CREATION
bq. storage-drivers/hbase/src/test/excluded-tests PRE-CREATION
bq. storage-drivers/hbase/src/test/log4j.xml PRE-CREATION
bq.
storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseSerDeResultConverter.java
PRE-CREATION
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseSerDeResultConverter.java
PRE-CREATION
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2061/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Francis
bq.
bq.
> ResultConverter for HBase Storage Drivers
> -----------------------------------------
>
> Key: HCATALOG-74
> URL: https://issues.apache.org/jira/browse/HCATALOG-74
> Project: HCatalog
> Issue Type: Sub-task
> Reporter: Francis Liu
> Assignee: Francis Liu
> Labels: HBASE
> Attachments: result_converter.patch, result_converter_rev2.patch,
> result_converter_rev3.patch
>
>
> ResultConverter and an implementation which wraps hive's HBaseSerDe needed by
> the storage drivers: HCATALOG-73 and HCATALOG-75
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
