----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2058/#review2426 -----------------------------------------------------------
good job fixing the inconsistency with HCatInputFormat. Your IDE seems to be doing some code auto-correction and it changed a lot of unrelated code in InitializeInput. Change only code related to the Jira. - Francis On 2011-10-06 19:23:55, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2058/ > ----------------------------------------------------------- > > (Updated 2011-10-06 19:23:55) > > > Review request for hcatalog and Francis Liu. > > > Summary > ------- > > This patch deals with the input storage driver for hbase. > > > This addresses bug https://issues.apache.org/jira/browse/HCATALOG-75. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HCATALOG-75 > > > Diffs > ----- > > /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 1178480 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java > PRE-CREATION > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java > PRE-CREATION > > /trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2058/diff > > > Testing > ------- > > I have added an additional junit test for the input storage driver. All the > existing tests along with the newly added one pass. > > > Thanks, > > Vandana > >
