----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2058/#review2448 -----------------------------------------------------------
Ship it! Looks good to me, we should make cache configurable though. /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java <https://reviews.apache.org/r/2058/#comment5559> https://github.com/apache/hbase/blob/trunk/src/main/resources/hbase-default.xml#L136 This param should control that already. The default is 1 which is bad for MR, so the 200 should be good for now. Maybe do if(cacheing <= 1) setCacheing(conf.getInt("hcat.hbase.cache.size.default", 200); - David On 2011-10-07 21:56:48, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2058/ > ----------------------------------------------------------- > > (Updated 2011-10-07 21:56:48) > > > Review request for hcatalog, Francis Liu and David Capwell. > > > Summary > ------- > > This patch deals with the input storage driver for hbase. > > > This addresses bug https://issues.apache.org/jira/browse/HCATALOG-75. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HCATALOG-75 > > > Diffs > ----- > > /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 1178480 > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java > PRE-CREATION > > /trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java > PRE-CREATION > > /trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2058/diff > > > Testing > ------- > > I have added an additional junit test for the input storage driver. All the > existing tests along with the newly added one pass. > > > Thanks, > > Vandana > >
