[
https://issues.apache.org/jira/browse/HCATALOG-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180053#comment-13180053
]
[email protected] commented on HCATALOG-191:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2813/#review4190
-----------------------------------------------------------
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
<https://reviews.apache.org/r/2813/#comment9442>
For repeatable reads this makes sense, but maybe this would be better as a
configuration?
If a large amount of users only care about 30 days worth of data but we
store all data that has ever existed, we would bloat HBase's regions on data we
dont care about. We should think about dropping data soon (not in this patch).
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
<https://reviews.apache.org/r/2813/#comment9443>
If the user calls this multiple times will it corrupt (or bloat) ZK's data?
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
<https://reviews.apache.org/r/2813/#comment9444>
use HConstant. ZOOKEEPER_CLIENT_PORT and HConstant.
DEFAULT_ZOOKEPER_CLIENT_PORT
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
<https://reviews.apache.org/r/2813/#comment9447>
this method knows about ZKBasedRevisonManager, it shouldn't need to. For
finding the base path it would be best to put that in the
ZKBasedRevisonManager's own logic rather than here.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
<https://reviews.apache.org/r/2813/#comment9446>
Should put this in ZKBasedRevisionManager.DEFAULT_DATADIR or something
- David
On 2012-01-03 18:07:56, Vandana Ayyalasomayajula wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2813/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-03 18:07:56)
bq.
bq.
bq. Review request for hcatalog, Francis Liu and David Capwell.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch contains the general changes required in hbase storage driver
for using revision manager. The actual integration between the read and write
side is still to be done.
bq.
bq.
bq. This addresses bug hcatalog-191.
bq. https://issues.apache.org/jira/browse/hcatalog-191
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseConstants.java
1211611
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
1211611
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java
1211611
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputStorageDriver.java
1211611
bq.
/trunk/storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HbaseSnapshotRecordReader.java
PRE-CREATION
bq.
/trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputStorageDriver.java
1211608
bq.
/trunk/storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestSnapshots.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2813/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. none.
bq.
bq.
bq. Thanks,
bq.
bq. Vandana
bq.
bq.
> HBase input storage driver integration with zookeeper based revision manager
> ----------------------------------------------------------------------------
>
> Key: HCATALOG-191
> URL: https://issues.apache.org/jira/browse/HCATALOG-191
> Project: HCatalog
> Issue Type: Sub-task
> Components: hbase
> Affects Versions: 0.3
> Reporter: Vandana Ayyalasomayajula
> Assignee: Vandana Ayyalasomayajula
> Priority: Minor
> Labels: hbase, storage_drivers
> Attachments: revision-mgmt-int.04.patch
>
>
> This jira deals with integration of HBase input storage driver with the
> zookeeper based revision manager. The record reader associated with the
> storage driver will filter record based out of the snapshot specification
> given by the user.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
