[
https://issues.apache.org/jira/browse/HCATALOG-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210404#comment-13210404
]
[email protected] commented on HCATALOG-241:
--------------------------------------------------------
bq. On 2012-02-16 03:26:37, Francis Liu wrote:
bq. > /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java, line 52
bq. > <https://reviews.apache.org/r/3819/diff/3/?file=75359#file75359line52>
bq. >
bq. > I see, this is no longer really a SerDe as hive would expect it to
be, it's more a converter. Just thinking if it'd be better for it not to
implement SerDe. Though we don't have to do that now, since this is already
checked in.
bq.
bq. Sushanth Sowmyan wrote:
bq. It's used as a convertor from this patch's code, but it is a SerDe
that uses HCatRecord as its writable type and as its object representation. I'd
prefer to retain it as-is rather than to strip it for utility methods in case
we ever revisit the need for a HCatRecordSerDe.
I hope we won't have to revisit that. I don't mind keeping it, just add some
documentation, since the reason for it being a serDe is no longer relevant in
the current state of things.
- Francis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3819/#review5150
-----------------------------------------------------------
On 2012-02-15 23:13:50, Sushanth Sowmyan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3819/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-15 23:13:50)
bq.
bq.
bq. Review request for Alan Gates and Francis Liu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Initial upload.
bq.
bq.
bq. This addresses bug HCATALOG-241.
bq. https://issues.apache.org/jira/browse/HCATALOG-241
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1244779
bq. /trunk/src/java/org/apache/hcatalog/data/DefaultHCatRecord.java 1244779
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecord.java 1244779
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
1244779
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1244779
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordable.java 1244779
bq. /trunk/src/java/org/apache/hcatalog/data/LazyHCatRecord.java
PRE-CREATION
bq. /trunk/src/test/org/apache/hcatalog/data/TestDefaultHCatRecord.java
1244779
bq. /trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java
1244779
bq.
/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java
1244779
bq.
/trunk/src/test/org/apache/hcatalog/rcfile/TestRCFileInputStorageDriver.java
1244779
bq.
bq. Diff: https://reviews.apache.org/r/3819/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sushanth
bq.
bq.
> Changes to HCatRecord to support switch from StorageDriver to SerDe
> -------------------------------------------------------------------
>
> Key: HCATALOG-241
> URL: https://issues.apache.org/jira/browse/HCATALOG-241
> Project: HCatalog
> Issue Type: Sub-task
> Affects Versions: 0.4
> Reporter: Alan Gates
> Assignee: Sushanth Sowmyan
> Fix For: 0.4
>
> Attachments: HCATALOG-241.patch, HCATALOG-241.patch.2,
> HCATALOG-241.patch.3, HCATALOG-241.patch.4
>
>
> This JIRA tracks changes to HCatRecord. See HCATALOG-237 for details and
> design notes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
