[
https://issues.apache.org/jira/browse/HCATALOG-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228500#comment-13228500
]
[email protected] commented on HCATALOG-308:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4309/#review5876
-----------------------------------------------------------
trunk/src/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java
<https://reviews.apache.org/r/4309/#comment12819>
we should change output at the same time to keep things consistent.
trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
<https://reviews.apache.org/r/4309/#comment12815>
I just noticed InputJobInfo has properties and jobProperties. How are they
different? If users are gonna pass implementation specific configs in job
properties now then we should make this line a merge instead of a replace.
trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
<https://reviews.apache.org/r/4309/#comment12816>
Not related. Didn't know this was still here.
trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java
<https://reviews.apache.org/r/4309/#comment12817>
you don't need this change. class members are null by default.
trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java
<https://reviews.apache.org/r/4309/#comment12818>
So this is new. Are you trying to mimic tableDesc? Since it has both
properties and jobProperties? So users should use jobProperties to pass
implementation specific parameters and properties is drawn from table and serde
configs?
- Francis
On 2012-03-13 12:09:33, Sushanth Sowmyan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4309/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-13 12:09:33)
bq.
bq.
bq. Review request for Alan Gates and Francis Liu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. + changing signature of configureInputJobProperties to take only
TableDesc, and to use its jobProperties
bq. + calling configureInputJobProperties at a table/job level, not at a
partition level.
bq.
bq.
bq. This addresses bug HCATALOG-308.
bq. https://issues.apache.org/jira/browse/HCATALOG-308
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1299936
bq. trunk/src/java/org/apache/hcatalog/mapred/HCatMapredInputFormat.java
1299936
bq. trunk/src/java/org/apache/hcatalog/mapred/HCatMapredOutputFormat.java
1299936
bq. trunk/src/java/org/apache/hcatalog/mapred/HiveHCatSplitWrapper.java
1299936
bq. trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java
1299936
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java
1299936
bq. trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1299936
bq. trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java 1299936
bq.
trunk/src/java/org/apache/hcatalog/storagehandler/HCatStorageHandlerImpl.java
1299936
bq. trunk/src/test/org/apache/hcatalog/cli/DummyStorageHandler.java 1299936
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
1299936
bq.
bq. Diff: https://reviews.apache.org/r/4309/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sushanth
bq.
bq.
> configureInputJobProperties(TableDesc) related changes
> ------------------------------------------------------
>
> Key: HCATALOG-308
> URL: https://issues.apache.org/jira/browse/HCATALOG-308
> Project: HCatalog
> Issue Type: Sub-task
> Reporter: Sushanth Sowmyan
> Assignee: Sushanth Sowmyan
> Fix For: 0.4
>
> Attachments: HCATALOG-308.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
