[ 
https://issues.apache.org/jira/browse/HCATALOG-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228596#comment-13228596
 ] 

[email protected] commented on HCATALOG-308:
--------------------------------------------------------



bq.  On 2012-03-13 15:15:01, Alan Gates wrote:
bq.  > trunk/src/java/org/apache/hcatalog/mapred/HCatMapredInputFormat.java, 
line 1
bq.  > <https://reviews.apache.org/r/4309/diff/1/?file=91628#file91628line1>
bq.  >
bq.  >     How is removing these files related to the rest of this patch?

This patch made some changes that would have made these not compile unless it 
was changed as well, and since this was a 0.3-only set of files, they needed to 
have been moved to .broken. So I could have either changed them to make it 
work, which was unnecessary, or removed them.


- Sushanth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4309/#review5875
-----------------------------------------------------------


On 2012-03-13 12:09:33, Sushanth Sowmyan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4309/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-13 12:09:33)
bq.  
bq.  
bq.  Review request for Alan Gates and Francis Liu.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  + changing signature of configureInputJobProperties to take only 
TableDesc, and to use its jobProperties
bq.  + calling configureInputJobProperties at a table/job level, not at a 
partition level.
bq.  
bq.  
bq.  This addresses bug HCATALOG-308.
bq.      https://issues.apache.org/jira/browse/HCATALOG-308
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1299936 
bq.    trunk/src/java/org/apache/hcatalog/mapred/HCatMapredInputFormat.java 
1299936 
bq.    trunk/src/java/org/apache/hcatalog/mapred/HCatMapredOutputFormat.java 
1299936 
bq.    trunk/src/java/org/apache/hcatalog/mapred/HiveHCatSplitWrapper.java 
1299936 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java 
1299936 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java 
1299936 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 
1299936 
bq.    trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java 1299936 
bq.    
trunk/src/java/org/apache/hcatalog/storagehandler/HCatStorageHandlerImpl.java 
1299936 
bq.    trunk/src/test/org/apache/hcatalog/cli/DummyStorageHandler.java 1299936 
bq.    
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
 1299936 
bq.  
bq.  Diff: https://reviews.apache.org/r/4309/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Sushanth
bq.  
bq.


                
> configureInputJobProperties(TableDesc) related changes
> ------------------------------------------------------
>
>                 Key: HCATALOG-308
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-308
>             Project: HCatalog
>          Issue Type: Sub-task
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>             Fix For: 0.4
>
>         Attachments: HCATALOG-308.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to