[
https://issues.apache.org/jira/browse/HCATALOG-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228780#comment-13228780
]
[email protected] commented on HCATALOG-310:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4313/#review5907
-----------------------------------------------------------
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpoint.java
<https://reviews.apache.org/r/4313/#comment12870>
Normally super.stop is called at the end. Should this be moved down or
does BaseEndointCoprocessor.stop do nothing?
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerFactory.java
<https://reviews.apache.org/r/4313/#comment12871>
Now that this is IN hbase can we just pass in the Configuration object?
Really not a fan of the selective pulling from conf to properties.
- David
On 2012-03-13 19:38:09, Thomas wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4313/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-13 19:38:09)
bq.
bq.
bq. Review request for Francis Liu, Vandana Ayyalasomayajula and David Capwell.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Initial patch for RevisionManager endpoint.
bq.
bq.
bq. This addresses bug HCATALOG-310.
bq. https://issues.apache.org/jira/browse/HCATALOG-310
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManagerEndpoint.java
PRE-CREATION
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/ManyMiniCluster.java
1300255
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/SkeletonHBaseTest.java
1300255
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/TableSnapshot.java
1300255
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerProtocol.java
PRE-CREATION
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerFactory.java
1300255
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseRevisionManagerUtil.java
1300255
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManager.java
1300255
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpoint.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4313/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. unit tests pass
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Turn current RM implementation into HBase Coprocessor
> -----------------------------------------------------
>
> Key: HCATALOG-310
> URL: https://issues.apache.org/jira/browse/HCATALOG-310
> Project: HCatalog
> Issue Type: Sub-task
> Components: hbase, storage handlers
> Affects Versions: 0.4
> Reporter: Thomas Weise
> Assignee: Thomas Weise
>
> Implement initial revision of endpoint and add new implementation of existing
> RM interface for HBase endpoint client. Add option to configure RM as
> endpoint. This will leave current default behavior as is (ZK based RM running
> per client in storage handler).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
