[
https://issues.apache.org/jira/browse/HCATALOG-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230363#comment-13230363
]
[email protected] commented on HCATALOG-310:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4313/#review5990
-----------------------------------------------------------
The RevisionManagerFactory responsiblity seems to be leaking into the
storageHandler code. storageHandler should just call the factory to instantiate
RevisionManager. Also should probably consider changing the methods a bit.
Split getRevisionManger into getRevisionManagerClient and
getRevisionManagerServer. Though it's not really clear to me if the Endpoint
needs to use the factory we can have an internal util to create a server
instance instead since the user will most like never need an instance of
revision manager server.
The Factory itself shouldn't depend on hadoop classes (ie Configuration)
because the original intent was that this library may be used for other storage
systems (ie Cassandra). We can revisit that idea but let's try to keep things
consistent with the original plan until a decision is made. We can probably
provide a util method which takes in the configuration object and return a
populated properties instance as part of the HBaseRevisionManagerUtil class.
Instead of having another factory for the EndPointClient its prolly cleaner to
have a class analogous to ZKBaseRevisionManager (ie HBaseClientRevisionManager)
which wraps the CoprocessorProxyClient.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManager.java
<https://reviews.apache.org/r/4313/#comment12985>
This should be part of the Factory class since this'll be mainly used there.
- Francis
On 2012-03-13 19:38:09, Thomas wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4313/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-13 19:38:09)
bq.
bq.
bq. Review request for Francis Liu, Vandana Ayyalasomayajula and David Capwell.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Initial patch for RevisionManager endpoint.
bq.
bq.
bq. This addresses bug HCATALOG-310.
bq. https://issues.apache.org/jira/browse/HCATALOG-310
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManagerEndpoint.java
PRE-CREATION
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/ManyMiniCluster.java
1300255
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/SkeletonHBaseTest.java
1300255
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/TableSnapshot.java
1300255
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerProtocol.java
PRE-CREATION
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerFactory.java
1300255
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseRevisionManagerUtil.java
1300255
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManager.java
1300255
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpoint.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4313/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. unit tests pass
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Turn current RM implementation into HBase Coprocessor
> -----------------------------------------------------
>
> Key: HCATALOG-310
> URL: https://issues.apache.org/jira/browse/HCATALOG-310
> Project: HCatalog
> Issue Type: Sub-task
> Components: hbase, storage handlers
> Affects Versions: 0.4
> Reporter: Thomas Weise
> Assignee: Thomas Weise
>
> Implement initial revision of endpoint and add new implementation of existing
> RM interface for HBase endpoint client. Add option to configure RM as
> endpoint. This will leave current default behavior as is (ZK based RM running
> per client in storage handler).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
