[
https://issues.apache.org/jira/browse/HCATALOG-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228885#comment-13228885
]
[email protected] commented on HCATALOG-308:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4309/#review5916
-----------------------------------------------------------
Ship it!
I have a concern with InputJobInfo not being deserialized when
configureInputProperties() is called which prevents storagehandler writers from
changing inputjobInfo but this is a non-issue for now. We can address it in a
separate jira.
- Francis
On 2012-03-14 00:24:56, Sushanth Sowmyan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4309/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-14 00:24:56)
bq.
bq.
bq. Review request for Alan Gates and Francis Liu.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. + changing signature of configureInputJobProperties to take only
TableDesc, and to use its jobProperties
bq. + calling configureInputJobProperties at a table/job level, not at a
partition level.
bq.
bq.
bq. This addresses bug HCATALOG-308.
bq. https://issues.apache.org/jira/browse/HCATALOG-308
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1300370
bq. trunk/src/java/org/apache/hcatalog/mapred/HCatMapredInputFormat.java
1300370
bq. trunk/src/java/org/apache/hcatalog/mapred/HCatMapredOutputFormat.java
1300370
bq. trunk/src/java/org/apache/hcatalog/mapred/HiveHCatSplitWrapper.java
1300370
bq.
trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
1300370
bq. trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java
1300370
bq. trunk/src/java/org/apache/hcatalog/mapreduce/HCatStorageHandler.java
1300370
bq. trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1300370
bq. trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java 1300370
bq. trunk/src/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java 1300370
bq.
trunk/src/java/org/apache/hcatalog/storagehandler/HCatStorageHandlerImpl.java
1300370
bq. trunk/src/test/org/apache/hcatalog/cli/DummyStorageHandler.java 1300370
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
1300370
bq.
trunk/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseRevisionManagerUtil.java
1300370
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputFormat.java
1300370
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputFormat.java
1300370
bq.
trunk/storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestSnapshots.java
1300370
bq.
bq. Diff: https://reviews.apache.org/r/4309/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Sushanth
bq.
bq.
> TableDesc and jobProperties related changes to configureInputJobProperties
> and configureOutputJobProperties
> -----------------------------------------------------------------------------------------------------------
>
> Key: HCATALOG-308
> URL: https://issues.apache.org/jira/browse/HCATALOG-308
> Project: HCatalog
> Issue Type: Sub-task
> Reporter: Sushanth Sowmyan
> Assignee: Sushanth Sowmyan
> Fix For: 0.4
>
> Attachments: HCATALOG-308.2.patch, HCATALOG-308.4.patch,
> HCATALOG-308.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
