[ 
https://issues.apache.org/jira/browse/HCATALOG-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229603#comment-13229603
 ] 

Sushanth Sowmyan edited comment on HCATALOG-308 at 3/14/12 8:58 PM:
--------------------------------------------------------------------

@Ashutosh :

Hive does not have configureInputJobProperties and configureOutputJobProperties 
methods yet, so this is not a change to hive's interface/signature. If, 
assuming your comment is because those changes did make it to hive already, no 
one would be using it yet.

Also, this is mimicking how hive actually handles this, by copying 
jobProperties back into TableDesc.

We wanted to make this change because we(Enis,Francis,Vandana and I) felt it 
was a simpler interface api for StorageHandler implementers - lesser 
parameters, and reduced duplicate functionality. And the sooner we make it the 
better - we don't want to have a more complex signature or go through a 
@Deprecation exercise.

@Alan :

Looking into it.
                
      was (Author: sushanth):
    @Ashutosh :

Hive does not have configureInputJobProperties and configureOutputJobProperties 
methods yet, so this is not a change to hive's interface/signature. If, 
assuming your comment is because those changes did make it to hive already, no 
one would be using it yet.

Also, this is mimicking how hive actually handles this, by copying 
jobProperties back into TableDesc.

We wanted to make this change because we(Enis,Francis,Vandana and I) felt it 
was a simpler interface api for StorageHandler implementers - lesser 
parameters, and reduced duplicate functionality.

@Alan :

Looking into it.
                  
> TableDesc and jobProperties related changes to configureInputJobProperties 
> and configureOutputJobProperties
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HCATALOG-308
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-308
>             Project: HCatalog
>          Issue Type: Sub-task
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>             Fix For: 0.4
>
>         Attachments: HCATALOG-308.2.patch, HCATALOG-308.4.patch, 
> HCATALOG-308.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to