----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4437/#review6594 -----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/MultiOutputFormat.java <https://reviews.apache.org/r/4437/#comment14261> Why call a static method each time? Could this not be a instance method? What about using the KeyValue class directly and just writing that to context? - David On 2012-03-30 16:36:00, Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4437/ > ----------------------------------------------------------- > > (Updated 2012-03-30 16:36:00) > > > Review request for hcatalog, Owen O'Malley, Ranjit Mathew, and Alejandro > Abdelnur. > > > Summary > ------- > > Patch description > 1) Created a Generic MultiOutputFormat instead of a hcat specific > MultiTableOutputFormat that can be later ported to mapreduce. > Classes - MultiOutputFormat.java, TestMultiOutputFormat.java. HCat > related tests for MultiOutputFormat in TestHCatMultiOutputFormat.java > 2) Added closeHiveClientQuietly() as unit tests were failing because of > HIVE-2883/HCATALOG-236 > 3) Added setting file permissions correctly for the output files in addition > to the partition directory in FileOutputCommitterContainer. This was required > with multiple tables. > > > This addresses bug HCATALOG-36. > https://issues.apache.org/jira/browse/HCATALOG-36 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/common/HCatUtil.java > 1307252 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java > 1307252 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java > 1307252 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputFormatContainer.java > 1307252 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/FosterStorageHandler.java > 1307252 > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/MultiOutputFormat.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java > PRE-CREATION > > http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/TestMultiOutputFormat.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4437/diff > > > Testing > ------- > > Unit and integration tested. > > > Thanks, > > Rohini > >
