-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4437/
-----------------------------------------------------------
(Updated 2012-04-25 18:37:12.418353)
Review request for hcatalog, Owen O'Malley, Ranjit Mathew, and Alejandro
Abdelnur.
Changes
-------
Minor change to work with recent change in dependencies. Removed google
collection utils used in test classes as guava is not in classpath anymore
after removing hive external.
Note:
Applying this patch and running tests will fail in TestMultiOutputFormat
without HCATALOG-388 patch because of slf4j incompatibilities.
Summary
-------
Patch description
1) Created a Generic MultiOutputFormat instead of a hcat specific
MultiTableOutputFormat that can be later ported to mapreduce.
Classes - MultiOutputFormat.java, TestMultiOutputFormat.java. HCat related
tests for MultiOutputFormat in TestHCatMultiOutputFormat.java
2) Added setting file permissions correctly for the output files in addition to
the partition directory in FileOutputCommitterContainer. This was required with
multiple tables.
This addresses bug HCATALOG-36.
https://issues.apache.org/jira/browse/HCATALOG-36
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
1329472
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/java/org/apache/hcatalog/mapreduce/MultiOutputFormat.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java
PRE-CREATION
http://svn.apache.org/repos/asf/incubator/hcatalog/trunk/src/test/org/apache/hcatalog/mapreduce/TestMultiOutputFormat.java
PRE-CREATION
Diff: https://reviews.apache.org/r/4437/diff
Testing
-------
Unit and integration tested.
Thanks,
Rohini
