[
https://issues.apache.org/jira/browse/HCATALOG-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245654#comment-13245654
]
[email protected] commented on HCATALOG-314:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4623/#review6659
-----------------------------------------------------------
/trunk/src/java/org/apache/hcatalog/common/HCatConstants.java
<https://reviews.apache.org/r/4623/#comment14377>
Nitpick. Some other name instead of CALLED would be better. LOCATION_SET or
something that is more related.
/trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java
<https://reviews.apache.org/r/4623/#comment14379>
We should be putting all configs. Not only ones that start with
HCAT_KEY_BASE.
Need to add credentials if it is not backend. We will have to store
credentials in UDFContext properties but remove it before the job is submitted
so that it is not part of the Configuration and appears in the UI.
/trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java
<https://reviews.apache.org/r/4623/#comment14380>
You can directly use for statement without having to use iterator.
/trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java
<https://reviews.apache.org/r/4623/#comment14385>
Need to do null check and .equals instead of !=
/trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java
<https://reviews.apache.org/r/4623/#comment14386>
Need to set all config and also credentials if not backend.
- Rohini
On 2012-04-03 18:43:12, Vandana Ayyalasomayajula wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4623/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-03 18:43:12)
bq.
bq.
bq. Review request for hcatalog, Francis Liu and Rohini Palaniswamy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HCatStorer.setStoreLocation() is called more than once by pig. Which ends
up calling HCatOutputFormat.setOutput multiple times.
HCatOutputFormat.setOutput should be called only once, the values that it
changed must be tracked and reapplied to job.getconfiguration() the succeeding
times it is called. HCatLoader may have the same issue and should be
investigated as well.
bq.
bq.
bq. This addresses bug hcatalog-314.
bq. https://issues.apache.org/jira/browse/hcatalog-314
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1309001
bq. /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1309001
bq. /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1309001
bq.
bq. Diff: https://reviews.apache.org/r/4623/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. The trunk builds are currently failing. I will run the entire test suite
once the build is fine.
bq.
bq.
bq. Thanks,
bq.
bq. Vandana
bq.
bq.
> HCatOutputFormat.setOutput is called more than once by HCatStorer
> -----------------------------------------------------------------
>
> Key: HCATALOG-314
> URL: https://issues.apache.org/jira/browse/HCATALOG-314
> Project: HCatalog
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Francis Liu
> Assignee: Vandana Ayyalasomayajula
>
> HCatStorer.setStoreLocation() is called more than once by pig. Which ends up
> calling HCatOutputFormat.setOutput multiple times. HCatOutputFormat.setOutput
> should be called only once, the values that it changed must be tracked and
> reapplied to job.getconfiguration() the succeeding times it is called.
> HCatLoader may have the same issue and should be investigated as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
