[
https://issues.apache.org/jira/browse/HCATALOG-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247685#comment-13247685
]
[email protected] commented on HCATALOG-314:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4623/
-----------------------------------------------------------
(Updated 2012-04-05 21:21:08.272978)
Review request for hcatalog, Francis Liu and Rohini Palaniswamy.
Changes
-------
- Removed code which stores job credentials into udf context.
- Added a private static variable in HCatStorer, where job credentials are
stored and retrieved for later use.
Summary
-------
HCatStorer.setStoreLocation() is called more than once by pig. Which ends up
calling HCatOutputFormat.setOutput multiple times. HCatOutputFormat.setOutput
should be called only once, the values that it changed must be tracked and
reapplied to job.getconfiguration() the succeeding times it is called.
HCatLoader may have the same issue and should be investigated as well.
This addresses bug hcatalog-314.
https://issues.apache.org/jira/browse/hcatalog-314
Diffs (updated)
-----
/trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1309184
/trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1309184
/trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1309184
Diff: https://reviews.apache.org/r/4623/diff
Testing
-------
The trunk builds are currently failing. I will run the entire test suite once
the build is fine.
Thanks,
Vandana
> HCatOutputFormat.setOutput is called more than once by HCatStorer
> -----------------------------------------------------------------
>
> Key: HCATALOG-314
> URL: https://issues.apache.org/jira/browse/HCATALOG-314
> Project: HCatalog
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Francis Liu
> Assignee: Vandana Ayyalasomayajula
>
> HCatStorer.setStoreLocation() is called more than once by pig. Which ends up
> calling HCatOutputFormat.setOutput multiple times. HCatOutputFormat.setOutput
> should be called only once, the values that it changed must be tracked and
> reapplied to job.getconfiguration() the succeeding times it is called.
> HCatLoader may have the same issue and should be investigated as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
