[
https://issues.apache.org/jira/browse/HCATALOG-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253610#comment-13253610
]
[email protected] commented on HCATALOG-314:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4623/#review6916
-----------------------------------------------------------
/trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java
<https://reviews.apache.org/r/4623/#comment15381>
We shouldn't use weakhashmap here. else we might lose delegation tokens
since you're not keeping a reference to the key.
/trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java
<https://reviews.apache.org/r/4623/#comment15386>
don't run this if running in the backend.
else if(!runningFromBackEnd){}
else {throw IllegalStateException())}
/trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java
<https://reviews.apache.org/r/4623/#comment15391>
same concerns with loader class. usage of weakhashmap and else if, else
statement.
- Francis
On 2012-04-10 22:13:03, Vandana Ayyalasomayajula wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4623/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-10 22:13:03)
bq.
bq.
bq. Review request for hcatalog, Francis Liu, Thomas, and Rohini Palaniswamy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HCatStorer.setStoreLocation() is called more than once by pig. Which ends
up calling HCatOutputFormat.setOutput multiple times.
HCatOutputFormat.setOutput should be called only once, the values that it
changed must be tracked and reapplied to job.getconfiguration() the succeeding
times it is called. HCatLoader may have the same issue and should be
investigated as well.
bq.
bq.
bq. This addresses bug hcatalog-314.
bq. https://issues.apache.org/jira/browse/hcatalog-314
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1312006
bq. /trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1312006
bq. /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1312006
bq.
bq. Diff: https://reviews.apache.org/r/4623/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Trunk build + tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Vandana
bq.
bq.
> HCatOutputFormat.setOutput is called more than once by HCatStorer
> -----------------------------------------------------------------
>
> Key: HCATALOG-314
> URL: https://issues.apache.org/jira/browse/HCATALOG-314
> Project: HCatalog
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Francis Liu
> Assignee: Vandana Ayyalasomayajula
>
> HCatStorer.setStoreLocation() is called more than once by pig. Which ends up
> calling HCatOutputFormat.setOutput multiple times. HCatOutputFormat.setOutput
> should be called only once, the values that it changed must be tracked and
> reapplied to job.getconfiguration() the succeeding times it is called.
> HCatLoader may have the same issue and should be investigated as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
