[ 
https://issues.apache.org/jira/browse/HCATALOG-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253920#comment-13253920
 ] 

Rohini Palaniswamy commented on HCATALOG-373:
---------------------------------------------

The Counters object is internal to the class and increment operations will not 
be reflected in the job counters. It would rather be better to leave it at 
empty implementation for incrCounter as before instead of having a local 
variable that will not be used anywhere. Or if you can fix it to call the 
TaskInputOutputContext (or the Reporter.NULL) methods for setStatus, 
incrCounter and getCounter it would be good. That way we can have 
RecordWriter's in the future that output some counters. 
                
> ProgressReporter should work with both old and new MR API
> ---------------------------------------------------------
>
>                 Key: HCATALOG-373
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-373
>             Project: HCatalog
>          Issue Type: Bug
>            Reporter: Travis Crawford
>            Assignee: Travis Crawford
>         Attachments: HCATALOG-373_progress_reporter.diff
>
>
> {{org.apache.hcatalog.mapreduce.ProgressReporter}} currently implements 
> {{org.apache.hadoop.mapred.Reporter}}. It should also extend 
> {{org.apache.hadoop.mapreduce.StatusReporter}} so it works with code 
> expecting either an old or new API reporter.
> The use case is using a wrapper so a serde works with a new-API input format.
> https://github.com/kevinweil/elephant-bird/blob/master/src/java/com/twitter/elephantbird/mapred/input/DeprecatedInputFormatWrapper.java#L163

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to