[
https://issues.apache.org/jira/browse/HCATALOG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255155#comment-13255155
]
[email protected] commented on HCATALOG-68:
-------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4732/#review6961
-----------------------------------------------------------
/trunk/src/java/org/apache/hcatalog/common/HCatLogUtil.java
<https://reviews.apache.org/r/4732/#comment15507>
You can pass the loglevel as argument to the method and cut down on the
number of methods. slf4j does not have support for it like other logging
systems, so you will have to do a switch case statement.
http://stackoverflow.com/questions/2621701/setting-log-level-of-message-at-runtime-in-slf4j
/trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java
<https://reviews.apache.org/r/4732/#comment15508>
Nitpick. It would be easier for readability and use if the static logger
variable name is all caps.
/trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java
<https://reviews.apache.org/r/4732/#comment15509>
We can remove e.getMessage() if we are logging t. If we only want to log
the message, then t is not required.
/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
<https://reviews.apache.org/r/4732/#comment15510>
{} is not required here. Couple of other places too
- Rohini
On 2012-04-16 21:16:58, Vandana Ayyalasomayajula wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4732/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-16 21:16:58)
bq.
bq.
bq. Review request for hcatalog, Sushanth Sowmyan, Francis Liu, and Thomas.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. We need to do the following things:
bq.
bq. + Use log4j across the board
bq. + Introduce a class with methods to help logging, refactoring away the
bunch of these functions in HCatUtil right now
bq. + Instrument debug logging with isLogEnabled checks on the log level
bq. + remove all instances of commented code whose purpose was for debug logs
bq.
bq.
bq. This addresses bug hcatalog-68.
bq. https://issues.apache.org/jira/browse/hcatalog-68
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
1325838
bq. /trunk/src/java/org/apache/hcatalog/common/HCatLogUtil.java PRE-CREATION
bq. /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1325838
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
1325838
bq.
/trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
1325838
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1325838
bq. /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java 1325838
bq.
/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1325838
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
1325838
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
1325838
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1325838
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1325838
bq. /trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java 1325838
bq. /trunk/src/test/org/apache/hcatalog/data/TestJsonSerDe.java 1325838
bq.
bq. Diff: https://reviews.apache.org/r/4732/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass. Log messages verified from test logs.
bq.
bq.
bq. Thanks,
bq.
bq. Vandana
bq.
bq.
> Logging from HCat
> -----------------
>
> Key: HCATALOG-68
> URL: https://issues.apache.org/jira/browse/HCATALOG-68
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Sushanth Sowmyan
> Assignee: Vandana Ayyalasomayajula
>
> We need to do the following things:
> + Use log4j across the board
> + Introduce a class with methods to help logging, refactoring away the
> bunch of these functions in HCatUtil right now
> + Instrument debug logging with isLogEnabled checks on the log level
> + remove all instances of commented code whose purpose was for debug logs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
