[
https://issues.apache.org/jira/browse/HCATALOG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255209#comment-13255209
]
[email protected] commented on HCATALOG-68:
-------------------------------------------------------
bq. On 2012-04-16 22:54:11, Rohini Palaniswamy wrote:
bq. >
/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java,
line 104
bq. > <https://reviews.apache.org/r/4732/diff/2/?file=102233#file102233line104>
bq. >
bq. > {} is not required here. Couple of other places too
if the {} is not used then the exception will not be logged. So either we do:
if( logger.isWarnEnabled()){
logger.warn("Failed to cancel delegation token," + e);
}
or logger.warn("Failed to cancel delegation token, {}", e);
bq. On 2012-04-16 22:54:11, Rohini Palaniswamy wrote:
bq. > /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java, line 172
bq. > <https://reviews.apache.org/r/4732/diff/2/?file=102232#file102232line172>
bq. >
bq. > We can remove e.getMessage() if we are logging t. If we only want to
log the message, then t is not required.
I have just replaced the existing logging with the new one. I have not written
this part of the source code, so I am not aware of the exact intention behind
it.
- Vandana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4732/#review6961
-----------------------------------------------------------
On 2012-04-16 21:16:58, Vandana Ayyalasomayajula wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4732/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-16 21:16:58)
bq.
bq.
bq. Review request for hcatalog, Sushanth Sowmyan, Francis Liu, and Thomas.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. We need to do the following things:
bq.
bq. + Use log4j across the board
bq. + Introduce a class with methods to help logging, refactoring away the
bunch of these functions in HCatUtil right now
bq. + Instrument debug logging with isLogEnabled checks on the log level
bq. + remove all instances of commented code whose purpose was for debug logs
bq.
bq.
bq. This addresses bug hcatalog-68.
bq. https://issues.apache.org/jira/browse/hcatalog-68
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
1325838
bq. /trunk/src/java/org/apache/hcatalog/common/HCatLogUtil.java PRE-CREATION
bq. /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1325838
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
1325838
bq.
/trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
1325838
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1325838
bq. /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java 1325838
bq.
/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1325838
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java
1325838
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
1325838
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1325838
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1325838
bq. /trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java 1325838
bq. /trunk/src/test/org/apache/hcatalog/data/TestJsonSerDe.java 1325838
bq.
bq. Diff: https://reviews.apache.org/r/4732/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass. Log messages verified from test logs.
bq.
bq.
bq. Thanks,
bq.
bq. Vandana
bq.
bq.
> Logging from HCat
> -----------------
>
> Key: HCATALOG-68
> URL: https://issues.apache.org/jira/browse/HCATALOG-68
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Sushanth Sowmyan
> Assignee: Vandana Ayyalasomayajula
>
> We need to do the following things:
> + Use log4j across the board
> + Introduce a class with methods to help logging, refactoring away the
> bunch of these functions in HCatUtil right now
> + Instrument debug logging with isLogEnabled checks on the log level
> + remove all instances of commented code whose purpose was for debug logs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
