[
https://issues.apache.org/jira/browse/HCATALOG-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272736#comment-13272736
]
[email protected] commented on HCATALOG-404:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5062/
-----------------------------------------------------------
(Updated 2012-05-10 20:48:36.475988)
Review request for hcatalog, Vandana Ayyalasomayajula and Thomas.
Changes
-------
Ok, I bit the bullet and fully integrated configuration into RM also moved the
configurable properties into RMConstants. I had to change a unit test as it
wasn't passing on my box, it looks like it was depending on unguaranteed mr
behavior (that splits are processed in some order) fixed that as well.
Summary
-------
revision manager currently expects some configs to be included in
hbase-site.xml, which complicates deployment as well as adding unrelated
properties which are not native hbase.
I've added a new class and revision-*.xml artifacts.
This addresses bug HCATALOG-404.
https://issues.apache.org/jira/browse/HCATALOG-404
Diffs (updated)
-----
storage-handlers/hbase/build.xml 6653a66
storage-handlers/hbase/conf/revision-manager-site.xml PRE-CREATION
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
d3faa04
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RMConstants.java
PRE-CREATION
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManager.java
24fc171
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerConfiguration.java
PRE-CREATION
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpoint.java
55c97e0
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpointClient.java
3e03909
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerFactory.java
cffcf5e
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/ZKBasedRevisionManager.java
6de6114
storage-handlers/hbase/src/resources/revision-manager-default.xml
PRE-CREATION
storage-handlers/hbase/src/test/log4j.xml 8fd4fc9
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputFormat.java
ee79d53
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputFormat.java
7808692
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseHCatStorageHandler.java
9dd8103
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputFormat.java
811d30f
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestSnapshots.java
9e78282
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManager.java
5cc9796
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManagerConfiguration.java
PRE-CREATION
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManagerEndpoint.java
1e94fd2
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestZNodeSetUp.java
ed85a47
Diff: https://reviews.apache.org/r/5062/diff
Testing
-------
Thanks,
Francis
> add separate configuration for revision manager
> -----------------------------------------------
>
> Key: HCATALOG-404
> URL: https://issues.apache.org/jira/browse/HCATALOG-404
> Project: HCatalog
> Issue Type: Improvement
> Affects Versions: 0.4.1
> Reporter: Francis Liu
> Assignee: Francis Liu
> Attachments: HCATALOG-404.patch
>
>
> revision manager currently expects some configs to be included in
> hbase-site.xml, which is complicates deployment and adding unrelated
> properties which are not native hbase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
