[
https://issues.apache.org/jira/browse/HCATALOG-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273739#comment-13273739
]
[email protected] commented on HCATALOG-404:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5062/#review7817
-----------------------------------------------------------
Ship it!
Could you add a sub task to this jira for moving all the defaults to
revision-manager.xml ?
storage-handlers/hbase/build.xml
<https://reviews.apache.org/r/5062/#comment17148>
I just ran ant package and confirmed that jar file has only -default.xml
and package command deposits -site.xml
- Vandana
On 2012-05-10 20:48:36, Francis Liu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5062/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 20:48:36)
bq.
bq.
bq. Review request for hcatalog, Vandana Ayyalasomayajula and Thomas.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. revision manager currently expects some configs to be included in
hbase-site.xml, which complicates deployment as well as adding unrelated
properties which are not native hbase.
bq.
bq. I've added a new class and revision-*.xml artifacts.
bq.
bq.
bq. This addresses bug HCATALOG-404.
bq. https://issues.apache.org/jira/browse/HCATALOG-404
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. storage-handlers/hbase/build.xml 6653a66
bq. storage-handlers/hbase/conf/revision-manager-site.xml PRE-CREATION
bq.
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseHCatStorageHandler.java
d3faa04
bq.
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RMConstants.java
PRE-CREATION
bq.
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManager.java
24fc171
bq.
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerConfiguration.java
PRE-CREATION
bq.
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpoint.java
55c97e0
bq.
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerEndpointClient.java
3e03909
bq.
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/RevisionManagerFactory.java
cffcf5e
bq.
storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/ZKBasedRevisionManager.java
6de6114
bq. storage-handlers/hbase/src/resources/revision-manager-default.xml
PRE-CREATION
bq. storage-handlers/hbase/src/test/log4j.xml 8fd4fc9
bq.
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputFormat.java
ee79d53
bq.
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputFormat.java
7808692
bq.
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseHCatStorageHandler.java
9dd8103
bq.
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseInputFormat.java
811d30f
bq.
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/TestSnapshots.java
9e78282
bq.
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManager.java
5cc9796
bq.
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManagerConfiguration.java
PRE-CREATION
bq.
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestRevisionManagerEndpoint.java
1e94fd2
bq.
storage-handlers/hbase/src/test/org/apache/hcatalog/hbase/snapshot/TestZNodeSetUp.java
ed85a47
bq.
bq. Diff: https://reviews.apache.org/r/5062/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Francis
bq.
bq.
> add separate configuration for revision manager
> -----------------------------------------------
>
> Key: HCATALOG-404
> URL: https://issues.apache.org/jira/browse/HCATALOG-404
> Project: HCatalog
> Issue Type: Improvement
> Affects Versions: 0.4.1
> Reporter: Francis Liu
> Assignee: Francis Liu
> Attachments: HCATALOG-404.patch, HCATALOG-404_2.patch
>
>
> revision manager currently expects some configs to be included in
> hbase-site.xml, which is complicates deployment and adding unrelated
> properties which are not native hbase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
