bharatviswa504 commented on a change in pull request #89: HDDS-2322.
DoubleBuffer flush termination and OM shutdown's after that. Make entry
returned from cache a new copy.
URL: https://github.com/apache/hadoop-ozone/pull/89#discussion_r340352841
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
##########
@@ -288,7 +289,17 @@ public Builder setKeyName(String key) {
public Builder setOmKeyLocationInfos(
List<OmKeyLocationInfoGroup> omKeyLocationInfoList) {
- this.omKeyLocationInfoGroups = omKeyLocationInfoList;
+ if (omKeyLocationInfoList != null) {
Review comment:
This will never be null, but someone can use this API and pass null, to
avoid those scenarios added that check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org
