bharatviswa504 commented on a change in pull request #89: HDDS-2322. 
DoubleBuffer flush termination and OM shutdown's after that. Make entry 
returned from cache a new copy.
URL: https://github.com/apache/hadoop-ozone/pull/89#discussion_r340353363
 
 

 ##########
 File path: 
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java
 ##########
 @@ -418,4 +436,37 @@ public boolean equals(Object o) {
   public int hashCode() {
     return Objects.hash(volumeName, bucketName, keyName);
   }
+
+  /**
+   * Return a new copy of the object.
+   */
+  public OmKeyInfo copyObject() {
 
 Review comment:
   Yes, it can be. As for Cloneable if it is not final class, I need to call 
super.clone() due to Cloneable semantics. And also to have the same way of this 
for all entities.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-h...@hadoop.apache.org

Reply via email to