[
https://issues.apache.org/jira/browse/HDFS-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747808#action_12747808
]
Suresh Srinivas commented on HDFS-543:
--------------------------------------
Comments:
# nit: Some of the lines exceed 80 chars
# TestSimulatedFSDataset.java - unrelated to this patch there are two warnings
of unused variables {{blockReport2}} and {{bytesAdded}}
# SimulatedFSDataset.java - unrelated to this patch private constructor is
unused
# TestWriteToReplica.java is missing. Not sure if that is intentional. Also
this test was not based on new junit.
> Break FSDatasetInterface#writeToBlock() into writeToTemporary, writeToRBW,
> and append
> -------------------------------------------------------------------------------------
>
> Key: HDFS-543
> URL: https://issues.apache.org/jira/browse/HDFS-543
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Affects Versions: Append Branch
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: Append Branch
>
> Attachments: writeToReplica.patch, writeToReplica1.patch
>
>
> FSDatasetInterface#writeToBlock() currently allows to create/recover a
> temporary replica, create/recover a RBW replica, or append to a replica. The
> implementation of the method in FSDataset is very complicated and error
> prone. I'd like to break this method into 3:
> 1. writeToTemporary allows to create a Temporary replica or recover from a
> packet error for a Tempoary replica;
> 2. writeToRBW allows to create a RBW replica or recover from a packet error
> for a RBW replica;
> 3. append allows to append to an existing Finalized replica.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
