[
https://issues.apache.org/jira/browse/HDFS-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748060#action_12748060
]
Hairong Kuang commented on HDFS-543:
------------------------------------
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 15 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
> Break FSDatasetInterface#writeToBlock() into writeToTemporary, writeToRBW,
> and append
> -------------------------------------------------------------------------------------
>
> Key: HDFS-543
> URL: https://issues.apache.org/jira/browse/HDFS-543
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node
> Affects Versions: Append Branch
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: Append Branch
>
> Attachments: writeToReplica.patch, writeToReplica1.patch,
> writeToReplica2.patch
>
>
> FSDatasetInterface#writeToBlock() currently allows to create/recover a
> temporary replica, create/recover a RBW replica, or append to a replica. The
> implementation of the method in FSDataset is very complicated and error
> prone. I'd like to break this method into 3:
> 1. writeToTemporary allows to create a Temporary replica or recover from a
> packet error for a Tempoary replica;
> 2. writeToRBW allows to create a RBW replica or recover from a packet error
> for a RBW replica;
> 3. append allows to append to an existing Finalized replica.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
