[ 
https://issues.apache.org/jira/browse/HDFS-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750020#action_12750020
 ] 

Suresh Srinivas commented on HDFS-537:
--------------------------------------

This change makes the existing code lot cleaner. Some minor comments:
# minor chage: BlockReceiver.java - setBytesAcked(), setNumBytes(), and other 
methods can check to see if the value passed is greater than what it already 
has. In that case, ReplicaInPipeline can ignore the passed value. This reduces 
code where these set methods are used.
# ReplicaInPipeline.createStreams() - not sure if the REMIND command is 
actionable and should be carried forward :-)


> DataNode uses ReplicaBeingWritten to support dfs writes/hflush
> --------------------------------------------------------------
>
>                 Key: HDFS-537
>                 URL: https://issues.apache.org/jira/browse/HDFS-537
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node
>    Affects Versions: Append Branch
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: Append Branch
>
>         Attachments: exposeReplicaInfo.patch
>
>
> This jira adds subdirectory "rbw" to data directory to support replicas 
> created on dfs writes/hflush, uses ReplicaBeingWritten to represent replicas 
> created on dfs writes/hflush, and some changes to make code more readable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to