[
https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767469#action_12767469
]
Konstantin Boudnik commented on HDFS-713:
-----------------------------------------
Here's the result of test-patch run:
{noformat}
There appear to be 104 release audit warnings before the patch and 104 release
audit warnings after applying the patch.
+1 overall.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
{noformat}
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it
> brings in more and more new test classes. In the current pipeline testing
> infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful
> about casting of a test object and make sure that it is of a proper type
> beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
