[
https://issues.apache.org/jira/browse/HDFS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767521#action_12767521
]
Tsz Wo (Nicholas), SZE commented on HDFS-713:
---------------------------------------------
+1 patch looks good.
Some thought: since hft may not be an instanceof HFlushTest, the variable name
(hft, acronym of HFlushTest) may be misleading.
> Need to properly check the type of the test class from an aspect
> ----------------------------------------------------------------
>
> Key: HDFS-713
> URL: https://issues.apache.org/jira/browse/HDFS-713
> Project: Hadoop HDFS
> Issue Type: Test
> Affects Versions: 0.22.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.22.0
>
> Attachments: HDFS-713.patch, HDFS-713.patch
>
>
> While the number of test cases using injection is constantly increasing it
> brings in more and more new test classes. In the current pipeline testing
> infrastructure inheritance of the classes becomes more complicated as well.
> The aspect for {{hflush()}} fault injection tests need to be more careful
> about casting of a test object and make sure that it is of a proper type
> beforehand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
