[
https://issues.apache.org/jira/browse/HDFS-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804898#action_12804898
]
Hadoop QA commented on HDFS-921:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431401/HDFS-921.patch
against trunk revision 902330.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/205/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/205/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/205/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/205/console
This message is automatically generated.
> Convert TestDFSClientRetries::testNotYetReplicatedErrors to Mockito
> -------------------------------------------------------------------
>
> Key: HDFS-921
> URL: https://issues.apache.org/jira/browse/HDFS-921
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HDFS-921.patch
>
>
> When TestDFSClientRetries::testNotYetReplicatedErrors was written, Mockito
> was not available and the NameNode was mocked by manually extending
> ClientProtocol and implementing all the methods, most with empty bodies. Now
> that we have Mockito, this code can be removed and replaced with an actual
> mock.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
