[
https://issues.apache.org/jira/browse/HDFS-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860781#action_12860781
]
Jakob Homan commented on HDFS-921:
----------------------------------
Hudson ran but didn't post:
{noformat} [exec] -1 overall. Here are the results of testing the latest
attachment
[exec]
http://issues.apache.org/jira/secure/attachment/12442795/HDFS-921-2.patch
[exec] against trunk revision 937855.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 core tests. The patch passed core unit tests.
[exec]
[exec] -1 contrib tests. The patch failed contrib unit tests.
{noformat}
Contrib test failure is unrelated.
> Convert TestDFSClientRetries::testNotYetReplicatedErrors to Mockito
> -------------------------------------------------------------------
>
> Key: HDFS-921
> URL: https://issues.apache.org/jira/browse/HDFS-921
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 0.22.0
>
> Attachments: HDFS-921-2.patch, HDFS-921.patch
>
>
> When TestDFSClientRetries::testNotYetReplicatedErrors was written, Mockito
> was not available and the NameNode was mocked by manually extending
> ClientProtocol and implementing all the methods, most with empty bodies. Now
> that we have Mockito, this code can be removed and replaced with an actual
> mock.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
