[ 
https://issues.apache.org/jira/browse/HDFS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864490#action_12864490
 ] 

Hadoop QA commented on HDFS-1132:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12443760/hdfs-1132-1.patch
  against trunk revision 939918.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: 
http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/344/console

This message is automatically generated.

> Refactor TestFileStatus
> -----------------------
>
>                 Key: HDFS-1132
>                 URL: https://issues.apache.org/jira/browse/HDFS-1132
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1132-1.patch
>
>
> When writing HADOOP-6585 I noticed TestFileStatus is an old test with just 
> one monolithic test function. We should rewrite it as a junit4 style test and 
> break up the functions into setup, teardown, and five individual test cases. 
> Same tests being run, just easier to follow, modify and add news tests. Patch 
> coming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to