[
https://issues.apache.org/jira/browse/HDFS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864612#action_12864612
]
Konstantin Boudnik commented on HDFS-1132:
------------------------------------------
Looks good.
Some comments:
- replace string literal {{io.file.buffer.size}} with
{{FSConstants.BUFFER_SIZE}}
- replace {{System.out.println}}'s with Log
- add diagnostic messages to the assert statements where they are missed
> Refactor TestFileStatus
> -----------------------
>
> Key: HDFS-1132
> URL: https://issues.apache.org/jira/browse/HDFS-1132
> Project: Hadoop HDFS
> Issue Type: Test
> Components: test
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hdfs-1132-1.patch, hdfs-1132-2.patch
>
>
> When writing HADOOP-6585 I noticed TestFileStatus is an old test with just
> one monolithic test function. We should rewrite it as a junit4 style test and
> break up the functions into setup, teardown, and five individual test cases.
> Same tests being run, just easier to follow, modify and add news tests. Patch
> coming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
