[
https://issues.apache.org/jira/browse/HDFS-7279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202894#comment-14202894
]
Tsz Wo Nicholas Sze commented on HDFS-7279:
-------------------------------------------
Reviewing the patch. Some questions/comments from the first half:
- In JspHelper.checkUsername(..), why removing the tryUgiParameter if-statement?
- In URLDispatcher.channelRead0(..), how about checking webhdfs uri first and
then use SimpleHttpProxyHandler for every else? I.e.
{code}
if (uri.startsWith("/webhdfs/v1")) {
WebHdfsHandler h = new WebHdfsHandler(conf, confForCreate);
p.replace(this, "proxy", h);
h.channelRead0(ctx, req);
} else {
SimpleHttpProxyHandler h = new SimpleHttpProxyHandler(proxyHost);
p.replace(this, "proxy", h);
h.channelRead0(ctx, req);
}
{code}
- DatanodeHttpServer.close() should throw IOException. Then, we don't need to
convert IOException to RuntimeException. Also, do we want to distory ssl
factory before closing the channel? Or put it in finally?
- In SimpleHttpProxyHandler,
-* Forwarder.channelRead(..): should the two LOG.warn be LOG.debug?
-* Forwarder.exceptionCaught(..): should the LOG.info be LOG.warn/error?
-* channelRead0(..): should the LOG.info be LOG.warn/error?
> Use netty to implement DatanodeWebHdfsMethods
> ---------------------------------------------
>
> Key: HDFS-7279
> URL: https://issues.apache.org/jira/browse/HDFS-7279
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, webhdfs
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-7279.000.patch, HDFS-7279.001.patch,
> HDFS-7279.002.patch, HDFS-7279.003.patch, HDFS-7279.004.patch,
> HDFS-7279.005.patch, HDFS-7279.006.patch, HDFS-7279.007.patch
>
>
> Currently the DN implements all related webhdfs functionality using jetty. As
> the current jetty version the DN used (jetty 6) lacks of fine-grained buffer
> and connection management, DN often suffers from long latency and OOM when
> its webhdfs component is under sustained heavy load.
> This jira proposes to implement the webhdfs component in DN using netty,
> which can be more efficient and allow more finer-grain controls on webhdfs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
