[
https://issues.apache.org/jira/browse/HDFS-7279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207473#comment-14207473
]
Haohui Mai commented on HDFS-7279:
----------------------------------
bq. In HdfsWriter, should the calls to releaseDfsResources() be put in
finally-blocks?
netty did it already. Calling {{releaseDfsResources()}} in
{{exceptionCaught()}} and {{channelInactive()}} is sufficient.
bq. In the code below, why 11? Is it due to "/webhdfs/v1".length? Would it work
if the URL has additional /, e.g. /webhdfs//v1/?
The request won't be redirected at the beginning. Note that the code can simply
return 404 for unnormalized URLs as they are generated from the NN.
bq. ParameterParser and WebHdfsHandler should reuse the Param classes in
org.apache.hadoop.hdfs.web.resources.
This is intentional. Ideally the code can use the reflection in jersey to parse
the parameters, but it requires several bridges in the netty side which I want
to avoid.
> Use netty to implement DatanodeWebHdfsMethods
> ---------------------------------------------
>
> Key: HDFS-7279
> URL: https://issues.apache.org/jira/browse/HDFS-7279
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, webhdfs
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-7279.000.patch, HDFS-7279.001.patch,
> HDFS-7279.002.patch, HDFS-7279.003.patch, HDFS-7279.004.patch,
> HDFS-7279.005.patch, HDFS-7279.006.patch, HDFS-7279.007.patch,
> HDFS-7279.008.patch
>
>
> Currently the DN implements all related webhdfs functionality using jetty. As
> the current jetty version the DN used (jetty 6) lacks of fine-grained buffer
> and connection management, DN often suffers from long latency and OOM when
> its webhdfs component is under sustained heavy load.
> This jira proposes to implement the webhdfs component in DN using netty,
> which can be more efficient and allow more finer-grain controls on webhdfs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
