[
https://issues.apache.org/jira/browse/HDFS-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242655#comment-14242655
]
Charles Lamb commented on HDFS-7506:
------------------------------------
[~wheat9],
I only have a few minor comments:
FSEditLogLoader.java:
The indentation for args in calls to #unprotectedSet{Owner,Quota,Times} are all
too far right. It should be 4 spaces.
FSDirectory.java:
line 312: introduces extra whitespace. While you in the neighborhood, you might
as well remove the import ...BlockStoragePolicySuite at line 57 since it's
unused.
You should also undue the change to the params of updateCount as it's unrelated
to the Jira.
> Consolidate implementation of setting inode attributes into a single class
> --------------------------------------------------------------------------
>
> Key: HDFS-7506
> URL: https://issues.apache.org/jira/browse/HDFS-7506
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-7506.000.patch, HDFS-7506.001.patch,
> HDFS-7506.002.patch
>
>
> This jira proposes to consolidate the implementation of setting inode
> attributes (i.e., times, permissions, owner, etc.) to a single class for
> better maintainability.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
