[
https://issues.apache.org/jira/browse/HDFS-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244440#comment-14244440
]
Jing Zhao commented on HDFS-7506:
---------------------------------
The patch looks pretty good to me. One minor comment is that it may be
unnecessary to define {{getStoragePolicies(blockManager)}} in {{FSDirAttrOp}}.
It may be more direct to call the method through blockManager. Besides of this
+1.
{code}
@@ -2181,25 +2046,18 @@ private void setStoragePolicyInt(String src, final
String policyName)
readLock();
try {
checkOperation(OperationCategory.READ);
- return blockManager.getStoragePolicies();
+ return FSDirAttrOp.getStoragePolicies(blockManager);
} finally {
readUnlock();
}
}
{code}
> Consolidate implementation of setting inode attributes into a single class
> --------------------------------------------------------------------------
>
> Key: HDFS-7506
> URL: https://issues.apache.org/jira/browse/HDFS-7506
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-7506.000.patch, HDFS-7506.001.patch,
> HDFS-7506.001.patch, HDFS-7506.002.patch
>
>
> This jira proposes to consolidate the implementation of setting inode
> attributes (i.e., times, permissions, owner, etc.) to a single class for
> better maintainability.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
