[
https://issues.apache.org/jira/browse/HDFS-6673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247622#comment-14247622
]
Andrew Wang commented on HDFS-6673:
-----------------------------------
Hey Eddy, thanks for working on this. It looks good, I don't see any major
issues, just some small nits:
* Needs a small rebase
* DelimitedImageViewer class javadoc typos: "included" -> "included in", "can
be" -> "can be set"
* TextWriterImageViewer javadoc: IOExceptions -> IOException
* We need some unit tests. I bet we have some for the old image viewer which
could be revived.
Since the purpose of this is all about large fsimages, have you tested this
with a large FSImage, and checked the memory usage / performance? Also curious
how we tune the LevelDB caches and write buffers, as described here:
https://code.google.com/p/leveldb/source/browse/include/leveldb/options.h
I think since LevelDB does its own write caching, we could also remove that
TODO about write batching.
> Add Delimited format supports for PB OIV tool
> ---------------------------------------------
>
> Key: HDFS-6673
> URL: https://issues.apache.org/jira/browse/HDFS-6673
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.4.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Minor
> Attachments: HDFS-6673.000.patch, HDFS-6673.001.patch,
> HDFS-6673.002.patch, HDFS-6673.003.patch
>
>
> The new oiv tool, which is designed for Protobuf fsimage, lacks a few
> features supported in the old {{oiv}} tool.
> This task adds supports of _Delimited_ processor to the oiv tool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
