[
https://issues.apache.org/jira/browse/HDFS-6673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14284506#comment-14284506
]
Andrew Wang commented on HDFS-6673:
-----------------------------------
Hi Eddy, thanks for doing these benchmarks. I only have some nitty stuff, it
overall looks great. I'm +1 pending these changes.
* Could use slf4j logging for new code.
* The use of {{String.format}} is often unnecessary, since slf4j and
Precondtion can already do the substitutions. It's more efficient to defer.
Using substitutions is also better than concatenating strings yourself with
{{+}}.
* Can we add some class javadoc on PBImageTextWriter describing the overall
process? It's nice to have an overview, even if a lot of the info is in other
bits of javadoc. For instance, mentioning the format of the PB image with
sections of records for INodes and directories, the two passes through the
fsimage used to first build the two different maps and then to print the
delimited format, being able to use LevelDB or the InMemoryDB to store the maps.
* Do we actually need to sync the metadata maps? This is all generated data, so
doesn't seem necessary, especially since this will typically be a one-time
thing and might decrease performance.
> Add Delimited format supports for PB OIV tool
> ---------------------------------------------
>
> Key: HDFS-6673
> URL: https://issues.apache.org/jira/browse/HDFS-6673
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 2.4.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Priority: Minor
> Attachments: HDFS-6673.000.patch, HDFS-6673.001.patch,
> HDFS-6673.002.patch, HDFS-6673.003.patch, HDFS-6673.004.patch,
> HDFS-6673.005.patch
>
>
> The new oiv tool, which is designed for Protobuf fsimage, lacks a few
> features supported in the old {{oiv}} tool.
> This task adds supports of _Delimited_ processor to the oiv tool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
