[ 
https://issues.apache.org/jira/browse/HDFS-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264803#comment-14264803
 ] 

Daryn Sharp commented on HDFS-7548:
-----------------------------------

The patch appears to mostly duplicate existing code just to prevent 
{{BlockPoolSliceScanner#addBlock}} from updating the {{lastScanTime}}.  Since 
this method is only called in one place, I'd suggest adding a "scanNow" 
boolean.  Update the current caller to pass false, the new try-catch can pass 
true.

Regarding the new try-catch, why catch IOE and re-throw if not 
ChecksumException versus explicitly catching ChecksumException?

> Corrupt block reporting delayed until datablock scanner thread detects it
> -------------------------------------------------------------------------
>
>                 Key: HDFS-7548
>                 URL: https://issues.apache.org/jira/browse/HDFS-7548
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.5.0
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>         Attachments: HDFS-7548.patch
>
>
> When there is one datanode holding the block and that block happened to be
> corrupt, namenode would keep on trying to replicate the block repeatedly but 
> it would only report the block as corrupt only when the data block scanner 
> thread of the datanode picks up this bad block.
> Requesting improvement in namenode reporting so that corrupt replica would be 
> reported when there is only 1 replica and the replication of that replica 
> keeps on failing with the checksum error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to