[
https://issues.apache.org/jira/browse/HDFS-7548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280980#comment-14280980
]
Daryn Sharp commented on HDFS-7548:
-----------------------------------
# In {{BlockPoolSliceScanner#updateBlockInfo}}, you should update the
nextScanType else the verification logs will never be able to change the value.
Probably something like set last to next, update next to normal verification
when updating the scanner.
# In {{BlockSender#sendPacket}}, I think you should only check the block in the
else clause. If the client socket closed then that doesn't imply a local error.
# I'd suggest following coding style of adding spaces after "if"
# You should add @VisibleForTesting to
{{DataBlockScanner#setLastScanTimeDifference}} or make the delta interval a
static and poke it.
> Corrupt block reporting delayed until datablock scanner thread detects it
> -------------------------------------------------------------------------
>
> Key: HDFS-7548
> URL: https://issues.apache.org/jira/browse/HDFS-7548
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Attachments: HDFS-7548-v2.patch, HDFS-7548-v3.patch, HDFS-7548.patch
>
>
> When there is one datanode holding the block and that block happened to be
> corrupt, namenode would keep on trying to replicate the block repeatedly but
> it would only report the block as corrupt only when the data block scanner
> thread of the datanode picks up this bad block.
> Requesting improvement in namenode reporting so that corrupt replica would be
> reported when there is only 1 replica and the replication of that replica
> keeps on failing with the checksum error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
