[ 
https://issues.apache.org/jira/browse/HDFS-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268329#comment-14268329
 ] 

Chris Nauroth commented on HDFS-7579:
-------------------------------------

Hi [~clamb].  This is a good idea.  Thanks for the patch.

One difference I see in this patch is that the logged value of 
{{numReportsSent}} is set to the length of the per-volume report list on both 
the "single message" and "split RPC per report" code paths.  Previously, this 
would have been 1 for the "single message" case.  I think the intent of this 
counter was to give an indication of the actual number of RPCs, so we'd want to 
keep 1 for the "single message" case.  Cc'ing [~arpitagarwal] for a second 
opinion.

> Improve log reporting during block report rpc failure
> -----------------------------------------------------
>
>                 Key: HDFS-7579
>                 URL: https://issues.apache.org/jira/browse/HDFS-7579
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 2.7.0
>            Reporter: Charles Lamb
>            Assignee: Charles Lamb
>            Priority: Minor
>              Labels: supportability
>         Attachments: HDFS-7579.000.patch
>
>
> During block reporting, if the block report RPC fails, for example because it 
> exceeded the max rpc len, we should still produce some sort of LOG.info 
> output to help with debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to