[ 
https://issues.apache.org/jira/browse/HDFS-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268364#comment-14268364
 ] 

Arpit Agarwal commented on HDFS-7579:
-------------------------------------

Thank you for the heads up Chris.

I agree that numReportsSent should be the number of RPCs and not 
reports.length. We could rename it to be clearer.

Couple of additional comments:
# _final int nCmds = cmds.size();_ should check for {{cmds}} being null.
# The logged message should give some indication whether or not all RPCs 
succeeded. Perhaps we can log something like _successfully completed x of y RPC 
calls_. For the usual case (no split), y would be 1. For the split case it 
would be {{reports.length}}.

> Improve log reporting during block report rpc failure
> -----------------------------------------------------
>
>                 Key: HDFS-7579
>                 URL: https://issues.apache.org/jira/browse/HDFS-7579
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 2.7.0
>            Reporter: Charles Lamb
>            Assignee: Charles Lamb
>            Priority: Minor
>              Labels: supportability
>         Attachments: HDFS-7579.000.patch
>
>
> During block reporting, if the block report RPC fails, for example because it 
> exceeded the max rpc len, we should still produce some sort of LOG.info 
> output to help with debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to