[
https://issues.apache.org/jira/browse/HDFS-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282989#comment-14282989
]
Tsz Wo Nicholas Sze commented on HDFS-7353:
-------------------------------------------
- There are quite a few classes added by the patch. Please add javadoc for all
the new classes.
- For XorRawEncoder/XorRawDecoder, we should have javadoc describing the class
but not only "Ported from HDFS-RAID".
{code}
+/**
+ * Ported from HDFS-RAID
+ */
+public class XorRawEncoder extends AbstractRawErasureEncoder{
{code}
- The word "Raw" can be dropped in the class names. For example,
AbstractRawErasureCoder is better to be called AbstractErasureCoder
> Raw Erasure Coder API for concrete encoding and decoding
> --------------------------------------------------------
>
> Key: HDFS-7353
> URL: https://issues.apache.org/jira/browse/HDFS-7353
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Fix For: HDFS-EC
>
> Attachments: HDFS-7353-v1.patch
>
>
> This is to abstract and define raw erasure coder API across different codes
> algorithms like RS, XOR and etc. Such API can be implemented by utilizing
> various library support, such as Intel ISA library and Jerasure library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
