[
https://issues.apache.org/jira/browse/HDFS-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289765#comment-14289765
]
Tsz Wo Nicholas Sze commented on HDFS-7353:
-------------------------------------------
Thanks for the update. Some comments:
- ec also can mean error correcting. How about renaming the package to
io.erasure? Then, using EC inside the package won't be ambiguous.
- Should the package be moved under hdfs? Do you expect that it will be used
outside hdfs?
- Please explain what it means by "Raw" in the javadoc.
- By "The number of elements", do you mean "length in bytes"? Should it be
long instead of int?
- The javadoc "An abstract raw erasure decoder class" does not really explain
what the class does. Could you add more description about how the class is
used and the relationship with the other classes?
- protected methods, especially the ones with abstract, should also has javadoc.
- There are some tab characters. We should replace them using spaces.
> Raw Erasure Coder API for concrete encoding and decoding
> --------------------------------------------------------
>
> Key: HDFS-7353
> URL: https://issues.apache.org/jira/browse/HDFS-7353
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Fix For: HDFS-EC
>
> Attachments: HDFS-7353-v1.patch, HDFS-7353-v2.patch
>
>
> This is to abstract and define raw erasure coder API across different codes
> algorithms like RS, XOR and etc. Such API can be implemented by utilizing
> various library support, such as Intel ISA library and Jerasure library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
