[
https://issues.apache.org/jira/browse/HDFS-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292614#comment-14292614
]
Tsz Wo Nicholas Sze commented on HDFS-7353:
-------------------------------------------
Thanks for the update. The new patch looks much better!
> ... It's not "length in bytes", but regarding how many stripping units. A
> unit can be a byte, a chunk or buffer and even a block.
How about renaming dataSize() and paritySize() to dataUnit() and parityUnit()?
BTW, the above sentence should be added to the javadoc. e.g.
{code}
+ /**
+ * The number of data stripping units for the coding. A unit can be a byte,
a chunk or buffer and even a block.
+ * @return
+ */
+ public int dataUnit() {
{code}
Some other comments:
- "A wrapper for ByteBuffer or bytes array" => "A wrapper for ByteBuffer or
bytes array for a erasure code chunk."
- AbstractRawErasureDecoder still has javadoc "An abstract raw erasure decoder
class". It needs more description.
- The @inheritDoc tags can be removed. Having a @Override tag is good enough.
- For RawErasureDecoder/RawErasureEncoder, we only need to provide the new
comment other than the ones in RawErasureCoder and have a reference to
RawErasureCoder, e.g.
{code}
/**
* RawErasureDecoder performs decoding given chunks of input data and generates
missing data that
* corresponds to an erasure code scheme, like XOR and Reed-Solomon.
* It implements the {@link RawErasureCoder} interface.
*/
{code}
> Raw Erasure Coder API for concrete encoding and decoding
> --------------------------------------------------------
>
> Key: HDFS-7353
> URL: https://issues.apache.org/jira/browse/HDFS-7353
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Fix For: HDFS-EC
>
> Attachments: HDFS-7353-v1.patch, HDFS-7353-v2.patch,
> HDFS-7353-v3.patch, HDFS-7353-v4.patch
>
>
> This is to abstract and define raw erasure coder API across different codes
> algorithms like RS, XOR and etc. Such API can be implemented by utilizing
> various library support, such as Intel ISA library and Jerasure library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
